Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Blend defintions #645

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

denz-e
Copy link
Contributor

@denz-e denz-e commented Nov 2, 2023

What?

Updated the Blend definitions as there was an error. Blend_call_BuyLocked contained the Blend_event_BuyLocked definition instead of Blend_call_buyLocked.

  • Blend_call_BuyLocked renamed to Blend_call_buyLocked and updated
  • Blend_event_BuyLocked added

How?

I used abi-parser or cli tools to build the table definitions

Related PRs (optional)

n/a

Anything Else?

@denz-e
Copy link
Contributor Author

denz-e commented Nov 3, 2023

Hi @medvedev1088 - I tried to rename Blend_call_BuyLocked.json to Blend_call_buyLocked.json (changed to lowercase b) but the change doesn't seem to get picked up when I'm creating the commits/PR. How should I proceed? This is the only error

@medvedev1088
Copy link
Member

The issue is that that the file name doesn't match the table_name field

@denz-e
Copy link
Contributor Author

denz-e commented Nov 3, 2023 via email

@daishuai323
Copy link
Collaborator

I tried to change the file name but it didn’t work. Is this possible?

Yeah it's possible. I was able to update the file name and it seems good now. Will merge this PR then

@daishuai323 daishuai323 merged commit ef01ab6 into blockchain-etl:master Dec 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants