Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hadolint docker #138

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Hadolint docker #138

merged 6 commits into from
Jan 29, 2025

Conversation

vladimirvolek
Copy link
Member

@vladimirvolek vladimirvolek commented Jan 29, 2025

Could you guys please fix the Dockerfile?

resolves: #51

CI

https://github.com/blockfrost/blockfrost-platform/actions/runs/13032676952/job/36355369616?pr=138

Locally

cargo install --force cargo-make
cargo make hadolint

[cargo-make] INFO - cargo make 0.37.24
[cargo-make] INFO - 
[cargo-make] INFO - Project: blockfrost-platform
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: hadolint
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: hadolint
Dockerfile:2 DL3027 warning: Do not use apt as it is meant to be a end-user tool, use apt-get or apt-cache instead
Dockerfile:28 DL3006 warning: Always tag the version of an image explicitly
Error while executing command, exit code: 1

@vladimirvolek vladimirvolek marked this pull request as ready for review January 29, 2025 13:48
Copy link

cloudflare-workers-and-pages bot commented Jan 29, 2025

Deploying blockfrost-platform with  Cloudflare Pages  Cloudflare Pages

Latest commit: 88245ab
Status: ✅  Deploy successful!
Preview URL: https://e90977a5.blockfrost-platform.pages.dev
Branch Preview URL: https://hadolint-docker.blockfrost-platform.pages.dev

View logs

@vladimirvolek vladimirvolek merged commit 25dc454 into main Jan 29, 2025
9 of 10 checks passed
@michalrus michalrus deleted the hadolint-docker branch January 30, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider changing our Dockerfile formatter
2 participants