feat: dnf module

[fiftydinar]

Changes

Recipe format

• Recipe format changed a bit, to satisfy the new feature of dnf flags.

Existing features code changes

• Adding repos is now using dnf -y config-manager addrepo --from-repofile=$repo for repo URLs & repo files, while COPR repos are using native dnf -y copr enable user/project.
  COPR repos are written in separate copr: array & in simpler user/project format in recipe, instead of long URL in repos: array.
• rpm-ostree override remove --install=$pkg is replaced with 2 operations of dnf removal & then install.
  Single operation of removal + installation of dnf doesn't currently exist, but it's not a breaking behavior to not have it.
• rpm-ostree override replace is replaced with dnf -y distro-sync --refresh --repo $repo $packages, which is compatible with all repos.
  Adding the repository along with replacement is disabled, so it must be done before replacement in repos: array if repo doesn't exist.

New features

• dnf group removal & installation. Those are declared as group-remove & group-install array in recipe.
  They run before the packages installation.
• Option for additional flags when doing installation or replacement of packages.
  • install-weak-dependencies: option for declaring if weak dependencies (such as Recommended) should be installed.
    It modifies the install & replace commands itself using --setopt=install_weak_deps=True/False flag, it doesn't modify the dnf config file. It defaults to true (reflecting dnf defaults).
  • skip-unavailable-packages: option for skipping unavailable packages when not available in repositories, or when not available on the system in case of replacing. Passes --skip-unavailable flag. Defaults to false.
  • skip-broken-packages: option for skipping the installation/replacement of broken packages. Passes --skip-broken flag. Defaults to false.
  • allow-erasing-packages: option for erasing/removing the problematic packages during dependency problems. Passes --allowerasing flag. Defaults to false.
• Option for additional flags when doing removal of packages.
  • remove-unused-dependencies is true by default. If false is specified, it passes the --no-autoremove flag, which won't remove any unused dependencies during removal operation.

Issues to be closed

Fixes: #361
Fixes: #370
Fixes: #325
Fixes: #282

[github-actions]

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

shellcheck

---

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Did you forget to close this double quoted string? SC1078

modules/modules/dnf/dnf.sh

Line 91 in cd91b05

CLASSIC_PKGS+=("${PKG}")

---

📝 [shellcheck] _{reported by reviewdog 🐶}
This is actually an end quote, but due to next char it looks suspect. SC1079

modules/modules/dnf/dnf.sh

Line 98 in cd91b05

echo "Installing: ${CLASSIC_PKGS[*]}"

---

🚫 [shellcheck] _{reported by reviewdog 🐶}
'(' is invalid here. Did you forget to escape it? SC1036

modules/modules/dnf/dnf.sh

Line 100 in cd91b05

echo "Installing package(s) directly from URL: ${HTTPS_PKGS[*]}"

---

🚫 [shellcheck] _{reported by reviewdog 🐶}
Expected 'fi' matching previously mentioned 'if'. SC1047

modules/modules/dnf/dnf.sh

Line 100 in cd91b05

echo "Installing package(s) directly from URL: ${HTTPS_PKGS[*]}"

---

🚫 [shellcheck] _{reported by reviewdog 🐶}
Expected 'fi'. Fix any mentioned problems and try again. SC1072

modules/modules/dnf/dnf.sh

Line 100 in cd91b05

echo "Installing package(s) directly from URL: ${HTTPS_PKGS[*]}"

[github-actions]

📝 [shellcheck] _{reported by reviewdog 🐶}
Possible misspelling: REPOS may not be assigned. Did you mean REPO? SC2153

modules/modules/rpm-ostree/rpm-ostree.sh

Line 8 in 1137c8b

if [[ ${#REPOS[@]} -gt 0 ]]; then

[xynydev]

Great final changes @gmpinder. Would y'all be fine if the repo thing I talked about above (#377 (comment)) were to be implemented?

[gmpinder]

Great final changes @gmpinder. Would y'all be fine if the repo thing I talked about above (#377 (comment)) were to be implemented?

Yeah I can totally do that

[gmpinder]

I made some changes to force an exit if dnf fails. There seems to be some assumptions I made that no longer hold. I'll have to make some more updates to fix that.