refactor: remove OpSpec #2074
Merged
refactor: remove OpSpec #2074
+160
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
reviewed
Feb 12, 2025
| @@ -35,27 +28,13 @@ impl OpSpecId { | |||
| } | |||
|
|
|||
| pub const fn is_enabled_in(self, other: OpSpecId) -> bool { | |||
| self as u8 <= other as u8 | |||
| other as u8 <= self as u8 | |||
There was a problem hiding this comment.
catched by tests below :)
rakita
approved these changes
Feb 12, 2025
CodSpeed Performance ReportMerging #2074 will improve performances by 2.15%Comparing Summary
Benchmarks breakdown
|
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
OpSpecenum and usesOpSpecIddirectlyAdditionally derived
Defaulton it