-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support byte array and data URIs via mimeType #1763
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
cbe4c41
Test data uri
Gustl22 fc8a547
Mp3 data uri
Gustl22 82ffbac
feat: Support data URIs and byte arrays
Gustl22 e7c3f20
implement on web
Gustl22 a05352a
Adapt duration
Gustl22 e4d2515
Merge remote-tracking branch 'upstream/main' into gustl22/1728-uri-te…
Gustl22 f31d4af
Adapt tests, features and sources
Gustl22 ce189ed
darwin: Attempt error handling
Gustl22 7a1a5a0
darwin: Attempt error handling
Gustl22 335adc1
darwin: Attempt error handling 3
Gustl22 b7ebbaf
darwin: Attempt error handling 4
Gustl22 b18db39
darwin: mimeType
Gustl22 19ee6d2
mime types
Gustl22 a8956a3
darwin: Error warning
Gustl22 1e84d9b
Format + Fix Optional
Gustl22 fa90368
Set mimetype for debug
Gustl22 58cce78
Adapt tests
Gustl22 7b84bde
Test with newest darwin OS
Gustl22 6d9494c
swift format (?)
Gustl22 4cb8f8c
WIP: Coverage of all macos & ios
Gustl22 967ea28
swift format
Gustl22 2aa17df
Log error
Gustl22 3aea341
Hand over mimeType
Gustl22 ac2b98b
Revert "Log error"
Gustl22 0b781a7
Attempt to fix
Gustl22 86b147e
Attempt to fix 2
Gustl22 af6e9dd
Attempt to fix 3
Gustl22 ca5b1f5
Use AVURLAssetOutOfBandMIMETypeKey for all versions / platforms
Gustl22 8580d9f
Revert "Use AVURLAssetOutOfBandMIMETypeKey for all versions / platforms"
Gustl22 d902852
Revert "Attempt to fix 3"
Gustl22 6a5b7ac
try macos-13
Gustl22 418aafc
download all ios
Gustl22 804bcde
Attempt to create specific device
Gustl22 7f48764
Install ios 16.4 device
Gustl22 1471576
Install ios 16 device
Gustl22 9d12ac6
Use static ios versions
Gustl22 6bafc0f
Specify udid
Gustl22 57f8eae
switch xcode
Gustl22 0d0f6d6
make ios tests ready
Gustl22 5287e73
finish up tests
Gustl22 890b38d
feat: Support bytes source and data URIs
Gustl22 9543ff4
Skip macOS 14 tests
Gustl22 a4a4252
fix error with download date time
Gustl22 c17c799
Merge remote-tracking branch 'upstream/main' into 1728-uri-test-data
Gustl22 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is just added as redundancy (like the other sources, but in a different format). But in order to make the tests faster, I commented them out. They are useful for testing certain scenarios though.