chore(example): Improved handling of platform context #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustl22
force-pushed
the
august/improve-example
branch
from
184a924 to
3bd472d
Compare
spydon
reviewed
Jan 26, 2025
Comment on lines
+34
to
+35
| bool isLocal = true; | ||
| bool isGlobal = false; |
There was a problem hiding this comment.
Aren't only one of these needed? They have an xor relationship right, it can't be both local and global at the same time?
There was a problem hiding this comment.
Good point actually. I had a look again, and both are acting a little bit differently:
- On iOS, local and global contexts act the same (until now) as no player specific contexts were necessary
- On Android, the global option only sets the default values for new players or can set
isSpeakerphoneOnoraudioMode. Also of course they can be applied to one player only.
So the options will only be applied to one player (local), as default in "global" context, or both.
So it should be possible to select global and local simultaneously (not the one or the other).
spydon
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
fix:,feat:,refactor:,docs:,chore:,test:,ci:etc).///, where necessary.Breaking Change
Related Issues