Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deployment action in CI #38

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Williangalvani
Copy link
Member

No description provided.

runs-on: ubuntu-latest
steps:
- name: Deploy BlueOS Extension
uses: BlueOS-community/Deploy-BlueOS-Extension@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: BlueOS-community/Deploy-BlueOS-Extension@v1
uses: BlueOS-community/Deploy-BlueOS-Extension@v1.0.1

We made a small update recently so it doesn't run as long when there aren't credentials provided - may as well use the latest :-)

Copy link
Contributor

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you don't want to add the timeouts CI is complaining about, or the docker credentials, LGTM :-)

@Williangalvani
Copy link
Member Author

Assuming you don't want to add the timeouts CI is complaining about, or the docker credentials, LGTM :-)

the credentials are there, I'm confused

@Williangalvani Williangalvani merged commit 7f9cd16 into bluerobotics:master Jan 30, 2024
0 of 2 checks passed
@Williangalvani Williangalvani deleted the deploy branch January 30, 2024 04:39
@ES-Alexander
Copy link
Contributor

the credentials are there, I'm confused

@Williangalvani remembered that apparently secrets are disabled for PRs, which does make some sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants