Add waypoint config panel to mission planning #1523

ArturoManzoli · 2025-01-03T12:14:15Z

To be merged after #1469

Adds a starter version of the Waypoint config panel, as part of the "Extend survey to generic MAVLink commands" implementation

Screenshare.-.2025-01-03.9_07_46.AM.mp4

rafaellehmkuhl · 2025-01-03T12:20:58Z

Hey Arturo, could you rebase this branch over master?

As it's based on #1469, you should actually rebase that one over master and them rebase this one over #1469.

ArturoManzoli · 2025-01-03T12:27:55Z

Hey Arturo, could you rebase this branch over master?

As it's based on #1469, you should actually rebase that one over master and them rebase this one over #1469.

Yep, I did push the wrong stuff.
Now it has only the diff to be added after merging #1469

rafaellehmkuhl · 2025-01-03T12:59:27Z

Hey Arturo, could you rebase this branch over master?
As it's based on #1469, you should actually rebase that one over master and them rebase this one over #1469.

Yep, I did push the wrong stuff. Now it has only the diff to be added after merging #1469

Much better! This will be a lot easier to review!

One thing: this seems to be rebased over master, not over the branch of #1469 (I can see that because the changes of #1469 are not here), but we can keep it this way as it will be easier to review, and rebase over master once we merge #1469.

Signed-off-by: Arturo Manzoli <[email protected]>

rafaellehmkuhl

Initial code review. Didn't test the changes extensively yet.

src/components/mission-planning/ContextMenu.vue

rafaellehmkuhl · 2025-01-21T20:03:04Z

src/views/MissionPlanningView.vue

+    if (selectedSurveyId.value === '') {
+      contextMenuType.value = 'map'
+      showContextMenu(e)
+    }
+    if (selectedSurveyId.value !== '') {
+      showContextMenu(e)
+    }


This expression can be simplified since showContextMenu(e) will always be called in the end.

rafaellehmkuhl · 2025-01-21T20:05:14Z

src/components/mission-planning/WaypointConfigPanel.vue

+  emit('removeWaypoint', waypoint)
+}
+
+const availableFrames = [


This should be typed using the AltitudeReferenceType enum so we never leave one left.

rafaellehmkuhl · 2025-01-21T20:06:00Z

src/components/mission-planning/WaypointConfigPanel.vue

+        ><p class="ml-4 text-center text-[13px] font-normal">
+          {{
+            selectedWaypoint.id === 'home'
+              ? 'Home'
+              : `Waypoint  ${missionStore.getWaypointNumber(selectedWaypoint?.id as string)}
+          parameters`
+          }}
+        </p></template
+      >


Those indentations can be better formatted.

rafaellehmkuhl · 2025-01-21T20:07:00Z

src/views/MissionPlanningView.vue

+              <svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg" style="display: block;">
+                <circle cx="10" cy="10" r="9" fill="white" stroke="#3B82F6" stroke-width="2"/>
+                <path d="M10 5V15M5 10H15" stroke="#3B82F6" stroke-width="2"/>
+              </svg>
+            `,


No need to reindent.

rafaellehmkuhl · 2025-01-21T20:07:49Z

src/views/MissionPlanningView.vue

-        <div class="survey-vertex-icon">
-          <svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
-            <circle cx="12" cy="12" r="5" fill="#3B82F6" stroke="white" stroke-width="2"/>
-          </svg>
-          <div class="delete-popup" style="display: none;">
-            <button class="delete-button">
-              <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
-                <path d="M2 4h12M4 4v10a2 2 0 002 2h4a2 2 0 002-2V4M6 4V2h4v2" 
-                      stroke="white" stroke-width="1.5" 
-                      stroke-linecap="round" stroke-linejoin="round"/>
-                </svg>
-              </button>
+          <div class="survey-vertex-icon">
+            <svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
+              <circle cx="12" cy="12" r="5" fill="#3B82F6" stroke="white" stroke-width="2"/>
+            </svg>
+            <div class="delete-popup" style="display: none;">
+              <button class="delete-button">
+                <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
+                  <path d="M2 4h12M4 4v10a2 2 0 002 2h4a2 2 0 002-2V4M6 4V2h4v2" 
+                        stroke="white" stroke-width="1.5" 
+                        stroke-linecap="round" stroke-linejoin="round"/>
+                  </svg>
+                </button>
+            </div>
          </div>
-        </div>
-      `,
+        `,


No need to reindent.

It looks like a lot of leftovers from the mission planning PR were readded here.

rafaellehmkuhl

Kapture.2025-01-24.at.14.50.11.mp4

It appears like there's a bug in this side menu.

rafaellehmkuhl · 2025-01-24T17:52:45Z

It seems like this patch is also breaking creation of simple path waypoints:

Kapture.2025-01-24.at.14.52.01.mp4

Edit: the problem happens after you click on a waypoint for the first time.

ArturoManzoli · 2025-01-27T12:36:41Z

On last patch:

Fixed visual bug on side menu;
Fixed WP adding bug;
Fixed WP coordinate inputs not reflecting on marker, only on lines;
Limited coordinates (display only) to 7 significant digits, so its under RTK gps resolution;
Modified the mouse cursor to a '+' when inside the add simple path mode;

rafaellehmkuhl

I'm clicking a waypoint to configure it but it doesn't seem to allow me anymore. It did in the previous version.

ArturoManzoli · 2025-01-28T19:22:35Z

I'm clicking a waypoint to configure it but it doesn't seem to allow me anymore. It did in the previous version.

Fixed!
It was related with the 7 decimal places display limit on coordinates.

…play Signed-off-by: Arturo Manzoli <[email protected]>

Signed-off-by: Arturo Manzoli <[email protected]>

ArturoManzoli · 2025-01-29T13:27:47Z

@rafaellehmkuhl
On last patch:

Fixed WP selection not working outside survey and path creation modes;
Updated button text to match 'simple path creation mode' closing;

rafaellehmkuhl · 2025-01-29T18:39:47Z

Working fine now!
Feel free to merge!

ArturoManzoli requested a review from rafaellehmkuhl January 3, 2025 12:14

ArturoManzoli marked this pull request as draft January 3, 2025 12:14

ArturoManzoli removed the request for review from rafaellehmkuhl January 3, 2025 12:14

ArturoManzoli force-pushed the add-waypoint-config-panel branch from 2d1b57d to ec4184e Compare January 3, 2025 12:25

Mission-planning: Change variable name to match UI

5148bcc

Signed-off-by: Arturo Manzoli <[email protected]>

ArturoManzoli force-pushed the add-waypoint-config-panel branch from ec4184e to 89bbdb1 Compare January 20, 2025 18:37

ArturoManzoli requested a review from rafaellehmkuhl January 20, 2025 18:41

ArturoManzoli marked this pull request as ready for review January 20, 2025 18:42

rafaellehmkuhl requested changes Jan 21, 2025

View reviewed changes

ArturoManzoli force-pushed the add-waypoint-config-panel branch 4 times, most recently from 66c7035 to a74bd4d Compare January 24, 2025 00:58

ArturoManzoli requested a review from rafaellehmkuhl January 24, 2025 01:00

rafaellehmkuhl requested changes Jan 24, 2025

View reviewed changes

ArturoManzoli force-pushed the add-waypoint-config-panel branch from a74bd4d to da7eab1 Compare January 27, 2025 12:33

ArturoManzoli requested a review from rafaellehmkuhl January 27, 2025 12:37

rafaellehmkuhl requested changes Jan 28, 2025

View reviewed changes

ArturoManzoli force-pushed the add-waypoint-config-panel branch from da7eab1 to 79e15d6 Compare January 28, 2025 19:20

ArturoManzoli requested a review from rafaellehmkuhl January 28, 2025 19:22

ArturoManzoli force-pushed the add-waypoint-config-panel branch from 79e15d6 to 1b15fa4 Compare January 28, 2025 20:53

ArturoManzoli requested review from rafaellehmkuhl and removed request for rafaellehmkuhl January 28, 2025 20:57

Mission-planning: Context-menu: Add waypoint mode and proprieties dis…

086ea9c

…play Signed-off-by: Arturo Manzoli <[email protected]>

Components: Side-config-panel: Simplify opening logic

Loading
Loading status checks…

0a92c96

Signed-off-by: Arturo Manzoli <[email protected]>

ArturoManzoli force-pushed the add-waypoint-config-panel branch from 1b15fa4 to 0a92c96 Compare January 29, 2025 13:25

ArturoManzoli requested review from rafaellehmkuhl and removed request for rafaellehmkuhl January 29, 2025 13:27

rafaellehmkuhl approved these changes Jan 29, 2025

View reviewed changes

ArturoManzoli merged commit 2db8ea0 into bluerobotics:master Jan 29, 2025
11 checks passed

ES-Alexander added the docs-needed label Jan 29, 2025

This was referenced Jan 30, 2025

bug: mission planning: dragging and removing waypoints doesn't work #1550

Closed

Prevent CSS leakage into mission planning module #1639

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add waypoint config panel to mission planning #1523

Add waypoint config panel to mission planning #1523

ArturoManzoli commented Jan 3, 2025 •

edited

Loading

rafaellehmkuhl commented Jan 3, 2025 •

edited

Loading

ArturoManzoli commented Jan 3, 2025

rafaellehmkuhl commented Jan 3, 2025

rafaellehmkuhl left a comment

rafaellehmkuhl Jan 21, 2025

rafaellehmkuhl Jan 21, 2025

rafaellehmkuhl Jan 21, 2025

rafaellehmkuhl Jan 21, 2025

rafaellehmkuhl Jan 21, 2025

rafaellehmkuhl left a comment

rafaellehmkuhl commented Jan 24, 2025 •

edited

Loading

ArturoManzoli commented Jan 27, 2025 •

edited

Loading

rafaellehmkuhl left a comment

ArturoManzoli commented Jan 28, 2025

ArturoManzoli commented Jan 29, 2025

rafaellehmkuhl commented Jan 29, 2025

Add waypoint config panel to mission planning #1523

Add waypoint config panel to mission planning #1523

Conversation

ArturoManzoli commented Jan 3, 2025 • edited Loading

rafaellehmkuhl commented Jan 3, 2025 • edited Loading

ArturoManzoli commented Jan 3, 2025

rafaellehmkuhl commented Jan 3, 2025

rafaellehmkuhl left a comment

Choose a reason for hiding this comment

rafaellehmkuhl Jan 21, 2025

Choose a reason for hiding this comment

rafaellehmkuhl Jan 21, 2025

Choose a reason for hiding this comment

rafaellehmkuhl Jan 21, 2025

Choose a reason for hiding this comment

rafaellehmkuhl Jan 21, 2025

Choose a reason for hiding this comment

rafaellehmkuhl Jan 21, 2025

Choose a reason for hiding this comment

rafaellehmkuhl left a comment

Choose a reason for hiding this comment

rafaellehmkuhl commented Jan 24, 2025 • edited Loading

ArturoManzoli commented Jan 27, 2025 • edited Loading

rafaellehmkuhl left a comment

Choose a reason for hiding this comment

ArturoManzoli commented Jan 28, 2025

ArturoManzoli commented Jan 29, 2025

rafaellehmkuhl commented Jan 29, 2025

ArturoManzoli commented Jan 3, 2025 •

edited

Loading

rafaellehmkuhl commented Jan 3, 2025 •

edited

Loading

rafaellehmkuhl commented Jan 24, 2025 •

edited

Loading

ArturoManzoli commented Jan 27, 2025 •

edited

Loading