Improve sensor detector usability #897
Conversation
patrickelectric
requested review from
jaxxzer,
tcanabrava and
Williangalvani
and removed request for
jaxxzer
|
Hi can you explain this one more. Which firmware version has the problem?
|
|
The firmware is our beta version, the ABR appears to fail with ping-viewer
in sometimes, it fails probably around 20%.
…On Thu, Feb 20, 2020 at 3:29 PM Jacob Walser ***@***.***> wrote:
Hi can you explain this one more. Which firmware version has the problem?
Ping1D has an unstable ABR procedure, where it fails to communicate with
115200 or 9600
in a not deterministic way.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#897?email_source=notifications&email_token=AAJIYCJH6A5FB5IQAJVN4PDRD3DYZA5CNFSM4KYBE422YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMPRQXQ#issuecomment-589240414>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJIYCKVKD7BEOLLAGT23STRD3DYZANCNFSM4KYBE42Q>
.
--
Patrick José Pereira
Electronics Engineer
Skype: patrickelectric434
IRC: patrickelectric
+55 (048) 99917-4777
|
|
I think the problem is on the qt side, the Ping1D 3.28 firmware is giving the expected response 100% of the time over here: bluerobotics/ping-python#82
|
|
@jaxxzer have you tested with ping-viewer master branch ? |
|
Yes, I've tried it right now and realized the issue you describe. |
| continue; | ||
| } | ||
|
|
||
| const auto indexRow = index(i); |
There was a problem hiding this comment.
explicit types when it's ipossible to guess the type by reading the code?
There was a problem hiding this comment.
indexRow = index(i) appears to be pretty clear that is an index value. We should also not care what type it's, since it's an argument for dataChanged.
Besides that, this happens in others parts of the code.
Removes baudrate and UDP port from user interface Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Sensor should deal with automatic baud rate procedure or communicate under 115200 Signed-off-by: Patrick José Pereira <[email protected]>
…rial filter Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
sensor_detection
branch
from
caaa3f6
to
8a2d9e8
Compare
Ping1D has an unstable ABR procedure, where it fails to communicate with 115200 or 9600
in a not deterministic way.
Such problem breaks the find device logic, where Ping1D fails to answer 115200 and
answers with 9600, this will make the 9600 baud rate valid and invalidate 115200 baud rates.
Doing the connection with such baudrate, will result in a poor performance for the user.
To avoid such problem, we are going to drop 9600 baud rate and ask the user to use manual connection.
The user can also update the firmware to use the automatic baud rate feature.
We are also hiding the serial baud rate and UDP connection port, making the interface cleaner and less confure.
Since the unstable nature of the ABR detection in Ping1D, this patch also allows the sensor to fail when being detected, the sensor can fail with this patch a max number of 3 times, after that the sensor will be considered unavailable (red circle).