Fail open on did cache (#1934)

fail open on did cache
bluesky-social · Dec 6, 2023 · 5038b50 · 5038b50
1 parent 10f934b
commit 5038b50
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/packages/bsky/src/did-cache.ts b/packages/bsky/src/did-cache.ts
@@ -42,7 +42,13 @@ export class DidRedisCache implements DidCache {
   }
 
   async checkCache(did: string): Promise<CacheResult | null> {
-    const got = await this.redis.get(did)
+    let got: string | null
+    try {
+      got = await this.redis.get(did)
+    } catch (err) {
+      got = null
+      log.error({ did, err }, 'error fetching did from cache')
+    }
     if (!got) return null
     const { doc, updatedAt } = JSON.parse(got) as CacheResult
     const now = Date.now()