Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interest tags to preferences #2086

Merged
merged 13 commits into from
Jan 25, 2024
Merged

Add interest tags to preferences #2086

merged 13 commits into from
Jan 25, 2024

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Jan 24, 2024

Adds a interests prop to preferences with the shape { onboardingTags: string[] }. I decided to use onboarding* prefix in case we improve this later and want to use the more generic tags key then.

Update: talked to Paul and we decided to just use tags instead of onboardingTags 👍

@estrattonbailey estrattonbailey marked this pull request as ready for review January 25, 2024 01:46
Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@estrattonbailey estrattonbailey merged commit 4171c04 into main Jan 25, 2024
10 checks passed
@estrattonbailey estrattonbailey deleted the eric/prefs-interests branch January 25, 2024 18:05
@github-actions github-actions bot mentioned this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants