Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appview v1 handling clearly bad cursors #2088

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

devinivy
Copy link
Collaborator

This adjusts the appview so that clearly mismatching cursors return an empty result set rather than failing with an error. Cursors that are close to the format but "not quite" there may still produce an error since it indicates some ambiguity. This should facilitate a potential change in the cursor format without significantly affecting consumers.

Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beaut ✨

@devinivy devinivy merged commit d03ddd0 into main Jan 26, 2024
10 checks passed
@devinivy devinivy deleted the appview-v1-bad-cursors branch January 26, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants