Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bold, italic and underline text #3297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

feat: bold, italic and underline text #3297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion lexicons/app/bsky/richtext/facet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"index": { "type": "ref", "ref": "#byteSlice" },
"features": {
"type": "array",
"items": { "type": "union", "refs": ["#mention", "#link", "#tag"] }
"items": { "type": "union", "refs": ["#mention", "#link", "#tag", "#bold", "#italic", "#underline"] }
}
}
},
Expand Down Expand Up @@ -38,6 +38,18 @@
"tag": { "type": "string", "maxLength": 640, "maxGraphemes": 64 }
}
},
"bold": {
"type": "object",
"description": "Facet feature for bold text."
},
"italic": {
"type": "object",
"description": "Facet feature for italic text."
},
"underline": {
"type": "object",
"description": "Facet feature for underlined text."
},
"byteSlice": {
"type": "object",
"description": "Specifies the sub-string range a facet feature applies to. Start index is inclusive, end index is exclusive. Indices are zero-indexed, counting bytes of the UTF-8 encoded text. NOTE: some languages, like Javascript, use UTF-16 or Unicode codepoints for string slice indexing; in these languages, convert to byte arrays before working with facets.",
Expand Down