-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen for searching user's posts #7622
base: samuel/search-lang-select-revamp
Are you sure you want to change the base?
Screen for searching user's posts #7622
Conversation
|
715a3fc
to
70a0b71
Compare
I just tried this out, it works really well, excellent job! I have one small suggestion: what about making the string in the menu conditional on whether you're looking at your own profile (I think it's something like social-app/src/view/com/profile/ProfileMenu.tsx Lines 218 to 221 in 1e1154a
Also, for reference, this would fix #2683, #2684 and the main request in #7018. |
e9edb10
to
f046028
Compare
Good idea! |
16c45be
to
48ef78f
Compare
8d7cee0
to
828caca
Compare
Based on #7591
Fixes #2683, #2684, #7018.
Note: I changed some copy text, so did a mass find+replace to prevent translation churn. commit to review is 1e1154a
Simulator.Screen.Recording.-.iPhone.16.-.2025-01-30.at.10.43.18.mp4
Test plan