Use separate temp directories per user for IPython kernel config files #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The temporary IPython kernel config files were previously saved to
/tmp/qserver/kernel_filesdirectory. The name is now changed to/tmp/qserver_<username>/kernel_filesto avoid issues with access permissions. A new kernel config file is created each time a console is started usingqserver-consoleorqserver-qtconsole.The changes are not expected to cause noticeable difference in the behavior of the queue server.
Fixed
The name of temporary directory used by
qserver-consoleandqserver-qtconsoleto store IPython kernel config file now contains user name (/tmp/qserver_<username>/kernel_files).Added
Changed
Removed
How Has This Been Tested?
Manually tested. The code is also covered by multiple unit tests.