Support multiple cheat codes with the same first letter #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… first letter
Previously, every cheat code required a unique first letter. This was stated in `event.cxx` near the definition of `cheat_code`:
*"Toutes les premières lettres doivent être différentes !"*
[All the first letters must be different!]
Right now, this change has no effect without adding new cheats.
This will have a greater effect for Speedy Blupi 2, as there are already 25 cheat codes ("V" is the only unused letter).
Skywalker13
reviewed
Feb 9, 2021
| // être différentes ! | ||
|
|
||
| static char cheat_code[9][20] = { | ||
| static char cheat_code[MAXCHEAT][CHEATLENGTH] = { |
There was a problem hiding this comment.
It's a very old and ugly original code. You should prefer "modern" stuff like std::array/std::vector with std::string when replacing old stuff.
Skywalker13
reviewed
Feb 9, 2021
| c++; // CONSTRUIRE ? | ||
| if ((char) event.key.keysym.sym == c) | ||
| bIncrement = false; | ||
| for (i = 0; i < MAXCHEAT; i++) |
There was a problem hiding this comment.
Then with std::array/std::vector we can use a for..rang loop instead of all these ugly for loop based on defines
Skywalker13
reviewed
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, every cheat code required a unique first letter. This was stated in
event.cxxnear the definition ofcheat_code:"Toutes les premières lettres doivent être différentes !"
[All the first letters must be different!]
Right now, this change has no effect without adding new cheats.
This will have a greater effect for Speedy Blupi 2, as there are already 25 cheat codes ("V" is the only unused letter).