Skip to content

Commit

Permalink
chore: address review
Browse files Browse the repository at this point in the history
  • Loading branch information
Benjamin-Frost committed Oct 15, 2024
1 parent f991da1 commit a98b534
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/pages/404.astro
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const langs = Object.keys(languages);
<script is:inline define:vars={{ langs, defaultLang }}>
const urlHasLang = langs.includes(location.pathname.split("/")[1]);

// First try to redirect to the user's locale (e.g., page could be monolingual)
// First, try to redirect to the default locale (e.g., page could be monolingual)
if (!urlHasLang) {
location.href = "/" + defaultLang + location.pathname;
return;
Expand Down
7 changes: 3 additions & 4 deletions src/pages/en/index.astro
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ const lang = (Astro.currentLocale || defaultLang) as Language;
<Hero
title="Welcome to the national centers of software development"
subtitle="We offer preparation for the world championships!"
,
/>
<HeadedSection
title="General Information"
Expand All @@ -32,9 +31,9 @@ const lang = (Astro.currentLocale || defaultLang) as Language;
manifestation of this initiative is
<Link href="https://www.worldskillsgermany.com" isExternal>
WorldSkills Germany</Link
>, which for example also hosts national and international competitions.
In Germany, a National Training Centre belongs to a each skill
respectively.
>, which, for example, also hosts national and international
competitions. In Germany, a National Training Centre belongs to a each
skill respectively.
</p>
<p>
The National Training Centres by WorldSkills Germany have the task of
Expand Down
3 changes: 1 addition & 2 deletions src/pages/en/mobile-applications-development.astro
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,11 @@ const historyData = historyJson[lang]["skill08"];
skillNumber="08"
skillName="Mobile Applications Development"
skillDescription="Mobile Applications Developers use technology and design to create apps which are appealing and function well on phones."
,
skillInformation={{
description:
"As a software developer with a specialization in mobile applications, you are a programmer and designer in one. You ensure that the apps work on users' mobile devices, look appealing, and are fun to use.<br /><br />For the job, you need a certain understanding of technology and design. You need to understand the requirements and wishes of the clients and develop a product that is reliable, updatable, and easy for users to understand and use.",
requirements:
"You master at least one programming language, e.g. Dart or Kotlin, and program mobile apps, including the connection to online APIs and the use of integrated sensors. You understand task in English.",
"You master at least one programming language, e.g. Dart or Kotlin, and program mobile apps, including the connection to online APIs and the use of integrated sensors. You understand tasks in English.",
videoUrl: "https://www.youtube.com/embed/Qe0ZaQAOQUY",
occupation: {
title: "A Career with a future and always on the cutting edge",
Expand Down
1 change: 0 additions & 1 deletion src/pages/index.astro
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ const lang = (Astro.currentLocale || defaultLang) as Language;
<Hero
title="Willkommen bei den Bundesleistungszentren der Softwareentwicklung"
subtitle="Wir bereiten auf die Weltmeisterschaften vor!"
,
/>
<HeadedSection
title="Allgemeine Informationen"
Expand Down

0 comments on commit a98b534

Please sign in to comment.