Fix: ManyToOne and ManyToMany relations.

Only concrete fields should be used.
bmispelon · May 21, 2024 · ced3d05 · ced3d05
1 parent 49d50c7
commit ced3d05
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/modelsubquery/functions.py b/src/modelsubquery/functions.py
@@ -13,7 +13,7 @@ def _model_fields(model, fields):
     then return all the declared fields.
     """
     # TODO: the pk/id field should always be returned
-    declared = {f.column for f in model._meta.get_fields()}
+    declared = {f.column for f in model._meta.get_fields() if f.concrete}
     if fields is None:
         return declared
 

diff --git a/testproject/testapp/models.py b/testproject/testapp/models.py
@@ -31,3 +31,8 @@ class Person(models.Model):
     birth = models.DateField(default=date.today)
 
     objects = PersonQuerySet.as_manager()
+
+
+class Shelve(models.Model):
+    title = models.CharField(max_length=100)
+    books = models.ManyToManyField("Book", related_name="shelves")