Merge pull request #2888 from buddh0/merge-02-11 #4006
Annotations
1 error
Run wagoid/commitlint-github-action@v5
You have commit messages with errors
⧗ input: cmd/devp2p/internal/ethtest: remove TD from status validation (#31137)
After recent changes in Geth (removing TD):
https://github.com/ethereum/go-ethereum/commit/39638c81c56db2b2dfe6f51999ffd3029ee212cb#diff-d70a44d4b7a0e84fe9dcca25d368f626ae6c9bc0b8fe9690074ba92d298bcc0d
Non-Geth clients are failing many devp2p tests with an error:
`peering failed: status exchange failed: wrong TD in status: have 1 want 0`
Right now only Geth is passing it - all other clients are affected by
this change. I think there should be no validation of TD when checking `Status`
message in hive tests. Now Geth has 0 (and hive tests requires 0) and
all other clients have actual TD. And on real networks there is no validation
of TD when peering
✖ footer's lines must not be longer than 100 characters [footer-max-line-length]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md
|
Loading