Skip to content

Merge pull request #2890 from bnb-chain/develop #4017

Merge pull request #2890 from bnb-chain/develop

Merge pull request #2890 from bnb-chain/develop #4017

Triggered via push February 14, 2025 07:47
Status Failure
Total duration 40s
Artifacts

commit-lint.yml

on: push
Matrix: commitlint
Fit to window
Zoom out
Zoom in

Annotations

1 error and 1 warning
commitlint (14.x, ubuntu-latest)
You have commit messages with errors ⧗ input: cmd/devp2p/internal/ethtest: remove TD from status validation (#31137) After recent changes in Geth (removing TD): https://github.com/ethereum/go-ethereum/commit/39638c81c56db2b2dfe6f51999ffd3029ee212cb#diff-d70a44d4b7a0e84fe9dcca25d368f626ae6c9bc0b8fe9690074ba92d298bcc0d Non-Geth clients are failing many devp2p tests with an error: `peering failed: status exchange failed: wrong TD in status: have 1 want 0` Right now only Geth is passing it - all other clients are affected by this change. I think there should be no validation of TD when checking `Status` message in hive tests. Now Geth has 0 (and hive tests requires 0) and all other clients have actual TD. And on real networks there is no validation of TD when peering ✖ footer's lines must not be longer than 100 characters [footer-max-line-length] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md
commitlint (14.x, ubuntu-latest)
Cache not found for keys: Linux-node-, Linux-node-