fix: fix pbss async node buffer force flush buffer #2885
Merged
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeylichang
reviewed
Feb 10, 2025
will-2012
reviewed
Feb 10, 2025
will-2012
reviewed
Feb 10, 2025
will-2012
previously approved these changes
Feb 10, 2025
galaio
reviewed
Feb 11, 2025
galaio
previously approved these changes
Feb 11, 2025
zzzckck
dismissed stale reviews from galaio and will-2012
The base branch was changed.
zzzckck
approved these changes
Feb 11, 2025
NathanBSC
approved these changes
Feb 11, 2025
buddh0
approved these changes
Feb 11, 2025
galaio
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
TestDisableUT failure.Rationale
Trie uses
bytesPoolto improve updateTrie performance to avoid extra memory allocation. However, PBSS uses asyncnodebuffer to store data which is a async operation. SoTestDisableUT cannot pass due to the data in PBSS is async mode and in UT use force flush.Example
N/A
Changes
Notable changes: