This repository has been archived by the owner on Feb 6, 2025. It is now read-only.
chore: add bsc and docker commands to readme #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Jul 1, 2024
README.md
Outdated
| --http \ | ||
| --http.addr=0.0.0.0 \ | ||
| --http.port=8545 \ | ||
| --http.api="admin, debug, eth, net, trace, txpool, web3, rpc, reth, ots, eth-call-bundle" \ |
There was a problem hiding this comment.
what is this eth-call-bundle for? I think as an example, just expose necessary API modules, "admin" "debug" seems not suggested by default?
unclezoro
reviewed
Jul 1, 2024
forcodedancing
force-pushed
the
add_bsc_cmd
branch
from
1b3e073 to
b5de6d4
Compare
forcodedancing
changed the title
forcodedancing
force-pushed
the
add_bsc_cmd
branch
from
b5de6d4 to
54c37d0
Compare
yutianwu
approved these changes
Jul 1, 2024
forcodedancing
force-pushed
the
add_bsc_cmd
branch
from
bb2acea to
9441111
Compare
unclezoro
approved these changes
Jul 1, 2024
pythonberg1997
added a commit
to pythonberg1997/reth
that referenced
this pull request
Jul 3, 2024
* ci: tag non-beta version as latest image (bnb-chain#51) * chore: add bsc and docker commands to readme (bnb-chain#50) * chore: add bsc commands to readme * fix review comments * fix op dockerfile issue * fix: spec mapping issue and snapshot overwrite issue (bnb-chain#52) * fix: system account status issue (bnb-chain#53) * test1 * test2 * test3 * test4 * test5 * test6 * test7 * test8 * update CI --------- Co-authored-by: dylanhuang <[email protected]> Co-authored-by: forcodedancing <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add bsc and dokcer commands to readme
Rationale
update readme
Example
NA
Changes
Notable changes: