Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GcObject to JsObject #1489

Merged
merged 4 commits into from
Aug 24, 2021

Conversation

bartlomieju
Copy link
Contributor

Related to #1376

@bartlomieju
Copy link
Contributor Author

@HalidOdat PTAL and let me know if you want to rename boa::Result to JsResult as well.

@Razican Razican added API enhancement New feature or request labels Aug 23, 2021
@Razican Razican added this to the v0.13.0 milestone Aug 23, 2021
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@Razican
Copy link
Member

Razican commented Aug 24, 2021

This just requires a rebase

@bartlomieju
Copy link
Contributor Author

This just requires a rebase

This is now done.

@Razican Razican merged commit 26e1497 into boa-dev:master Aug 24, 2021
@bartlomieju bartlomieju deleted the rename_gcobject_to_jsobject branch August 24, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants