Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Temporal.PlainTime and Temporal.Duration constructors #4078

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Dec 9, 2024

This Pull Request is related to ongoing work for #4070.

It changes the following:

  • Adds JsValue::map_or method
  • Fixes handling of undefined arguments to both the PlainTime constructor and the Duration constructor

Copy link

github-actions bot commented Dec 9, 2024

Test262 conformance changes

Test result main count PR count difference
Total 48,494 48,494 0
Passed 43,680 43,694 +14
Ignored 1,500 1,500 0
Failed 3,314 3,300 -14
Panics 0 0 0
Conformance 90.07% 90.10% +0.03%
Fixed tests (22):
test/built-ins/Temporal/PlainTime/minute-undefined.js (previously Failed)
test/built-ins/Temporal/PlainTime/second-undefined.js (previously Failed)
test/built-ins/Temporal/PlainTime/millisecond-undefined.js (previously Failed)
test/built-ins/Temporal/PlainTime/hour-undefined.js (previously Failed)
test/built-ins/Temporal/PlainTime/nanosecond-undefined.js (previously Failed)
test/built-ins/Temporal/PlainTime/microsecond-undefined.js (previously Failed)
test/built-ins/Temporal/Duration/months-undefined.js (previously Failed)
test/built-ins/Temporal/Duration/years-undefined.js (previously Failed)
test/built-ins/Temporal/Duration/weeks-undefined.js (previously Failed)
test/built-ins/Temporal/Duration/microseconds-undefined.js (previously Failed)
test/built-ins/Temporal/Duration/hours-undefined.js (previously Failed)
test/built-ins/Temporal/Duration/nanoseconds-undefined.js (previously Failed)
test/built-ins/Temporal/Duration/days-undefined.js (previously Failed)
test/built-ins/Temporal/Duration/minutes-undefined.js (previously Failed)
test/built-ins/Temporal/Duration/seconds-undefined.js (previously Failed)
test/built-ins/Temporal/Duration/milliseconds-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/minute-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/second-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/millisecond-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/hour-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/nanosecond-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/microsecond-undefined.js (previously Failed)
Broken tests (8):
test/built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-timezone-string-year-zero.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-string-zoneddatetime-wrong-offset.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/total/relativeto-wrong-type.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/toString/smallestunit-invalid-string.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/toString/fractionalseconddigits-out-of-range.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/toString/fractionalseconddigits-invalid-string.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/toString/roundingmode-invalid-string.js (previously Passed)
test/built-ins/Temporal/Duration/prototype/toString/fractionalseconddigits-nan.js (previously Passed)

@nekevss
Copy link
Member Author

nekevss commented Dec 9, 2024

Note: Broken tests in this instance are false positives that are now flagging correctly due to the error change.

@nekevss nekevss requested review from jasonwilliams, jedel1043 and a team December 9, 2024 21:34
@nekevss nekevss added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Dec 9, 2024
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love map_or.

@nekevss nekevss requested a review from a team December 11, 2024 19:42
@raskad raskad added this to the next-release milestone Dec 11, 2024
@raskad raskad added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit f5ba695 Dec 11, 2024
13 checks passed
@raskad raskad deleted the patch-time-duration-constructors branch December 11, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants