Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package device #159

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Add package device #159

merged 1 commit into from
Sep 19, 2023

Conversation

ChriMarMe
Copy link
Contributor

Add package device which defines an interface "IODEvice" and implements several devices which operate on IO-Ports of a vCPU

bobuhiro11
bobuhiro11 reviewed Sep 15, 2023
View reviewed changes
Copy link
Owner

@bobuhiro11 bobuhiro11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't read the whole code yet, but here are my comments so far.

device/device.go Show resolved Hide resolved
device/acpi_pm_timer.go Outdated Show resolved Hide resolved
device/acpi_pm_timer.go Show resolved Hide resolved
bobuhiro11
bobuhiro11 reviewed Sep 17, 2023
View reviewed changes
Copy link
Owner

@bobuhiro11 bobuhiro11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements!
I made additional comments.

device/acpi_shutdown_device.go Show resolved Hide resolved
device/fw_debug_device.go Outdated Show resolved Hide resolved
device/fw_debug_device.go Outdated Show resolved Hide resolved
device/fw_debug_device.go Show resolved Hide resolved
device/cmos.go Show resolved Hide resolved
@ChriMarMe ChriMarMe force-pushed the add_package/device branch 3 times, most recently from 574a8b7 to e8425f7 Compare September 18, 2023 06:47
@ChriMarMe
Add package device
0246fab 
Signed-off-by: Christopher Meis <[email protected]>
bobuhiro11
bobuhiro11 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Owner

@bobuhiro11 bobuhiro11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the minor improvements!
It looks good :)

device/cmos.go Show resolved Hide resolved
@bobuhiro11 bobuhiro11 merged commit 34db82b into bobuhiro11:main Sep 19, 2023
@ChriMarMe ChriMarMe deleted the add_package/device branch September 19, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobuhiro11 bobuhiro11 bobuhiro11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChriMarMe @bobuhiro11