BUG: Fixes Bug in K22F that is caused by infra-clades as terminal taxons #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fra-clade was the terminal taxon Co-authored-by: colinvwood
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
==========================================
- Coverage 95.60% 95.41% -0.19%
==========================================
Files 34 34
Lines 1956 1984 +28
Branches 226 233 +7
==========================================
+ Hits 1870 1893 +23
- Misses 48 49 +1
- Partials 38 42 +4 ☔ View full report in Codecov by Sentry. |
cherman2
changed the title
ebolyen
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: fixes a bug in Kraken2-to-features that caused an error if an infra-clade was the terminal taxon.
If Bracken is run before kraken2-to-features, this is not an issue becuase bracken would estimate down to the species, so this bug only occurs if Kraken2-to-features is run independently.
Co-authored-by: @colinvwood