Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autosuggest #101

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Fix autosuggest #101

wants to merge 13 commits into from

Conversation

Okisa
Copy link
Member

@Okisa Okisa commented Feb 1, 2023

PR Template

Thanks for opening a PR!

Context

GitHub Issue:
#100

Version Number:
4.0.2-beta.4

Checklist

  • Has been verified in an integrated environment
  • Has relevant unit and integration tests passing
  • Has no linting, test console, or browser console errors (best effort)
  • Has JSDoc comment blocks for complex code

PR Review Guidance

  • Test if AutoSuggest input works correctly using the keyboard - Options should have values with spaces in it.
  • Tested on Flow 3.12.30

LucasGrimauth
LucasGrimauth previously approved these changes Feb 1, 2023
Copy link
Member

@LucasGrimauth LucasGrimauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The autosuggest works well with keyboard and with spaces in the input!

Copy link
Member

@timrbula timrbula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isakawa-carbon Nice work on this! It works well. Do you mind updating/adding comments for how it works and making sure that the code is formatted w/ prettier?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants