Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for dot and bracket parameter notation #200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amhudson
Copy link
Member

@amhudson amhudson commented Jun 10, 2022

Closes #

boomerang-io/community#345

Changelog

New

  • Adding support for dot and bracket parameter notation

Changed

  • N/A

Removed

  • N/A

Testing / Reviewing

Tested and verified locally

@amhudson amhudson requested a review from tlawrie June 10, 2022 17:25
@amhudson amhudson self-assigned this Jun 10, 2022
@gitguardian
Copy link

gitguardian bot commented Jun 10, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
70871 Generic High Entropy Secret 2a05964 src/test/java/io/boomerang/tests/controller/WorkflowControllerTests.java View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link
Member

@tlawrie tlawrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @amhudson i think lets do a session on this in the next Boomerang community call. I think we could also be changing this in the Parameter Manager

I've rewritten part of this in https://github.com/boomerang-io/flow.service.engine/blob/main/src/main/java/io/boomerang/service/ParameterManagerImpl.java

It still uses the paramLayers and builds them up. But i think overall we could solve this similar to how you have it.

@amhudson amhudson requested a review from marcusdroy as a code owner October 12, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants