Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update solidus compatibility #22

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update solidus compatibility #22

wants to merge 8 commits into from

Conversation

fastjames
Copy link

Update the CI testing matrix so we cover Solidus versions currently
under maintenance.

I tried this once and I think I tried to cover too many Solidus versions in one go. This time I'm going to take smaller steps.

@fastjames fastjames mentioned this pull request Oct 25, 2019
Closed
@fastjames fastjames force-pushed the update_solidus_compat branch from 6e39729 to ddf157c Compare October 25, 2019 16:06
@fastjames
Update solidus compatibility
73d1bd8 
Update the CI testing matrix so we cover Solidus versions currently
under maintenance.
@fastjames
Add Solidus 2.7 to CI matrix
63e5804
@fastjames
fixup: update bundler to use HTTPS for github
7ba5b39
@fastjames
Add v2.8 to CI matrix
4a43ce0 
This commit also resolves the deprecations for v2.8 and one test error
resulting from a missing I18n translation.

Side note: this is the first step in this branch where there are _no_
outstanding deprecations. Yay!
@fastjames
Add Solidus v2.9 to CI matrix
57db636 
Add Solidus v2.9 to the test matrix, and clear up broken specs. This
required moving from poltergeist to selenium, and a few changes to some
of the feature specs.
@fastjames
Add master to CI test matrix
fb7bc12 
Add the solidus `master` branch to the CI test matrix. This should allow
us to spot and fix compatibility problems more quickly.
@fastjames fastjames force-pushed the update_solidus_compat branch from 639f309 to fb7bc12 Compare October 25, 2019 20:07
@fastjames
Copy link
Author

Look at that, finally passing on all versions! I'm happy to squash it before merge.

@fastjames fastjames mentioned this pull request Oct 28, 2019
Closed
@fastjames
Copy link
Author

I have updated this PR to include v2.10.

@afdev82
Copy link

afdev82 commented Jun 15, 2020

any update on this?

@dhonig
Copy link
Contributor

dhonig commented Jun 15, 2020 via email

@fastjames
Copy link
Author

I have not looked at this in several months. Is it missing a new version?

@afdev82
Copy link

afdev82 commented Jun 16, 2020

Yes,
maybe I would need to use this extension for one project, but I'm not sure yet.
In that case I would be happy to contribute, but I asked to know the current status of this extension.
I used some extensions in the past and they needed refactoring to use the latest solidus because they were quite abandoned.

We can work on getting this merged if you are interested, you can also send a PR?
…
On Mon, Jun 15, 2020 at 4:38 PM Antonio Facciolo @.***> wrote: any update on this? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#22 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZTL2WRJ2KRKVO5R4RXXTRW2BD5ANCNFSM4JFFAFXA .

Marciobds added a commit to Marciobds/solidus_flexi_variants that referenced this pull request Mar 12, 2021
@Marciobds
Commits de Update solidus compatibility boomerdigital#22
58829b0
@jeremygpeterson jeremygpeterson mentioned this pull request Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fastjames @afdev82 @dhonig