에러 리스트의 에러들을 해결 #184
Merged
에러 리스트의 에러들을 해결 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- setFeatureStyle파일에서 isChanged검사가 빠져있어서 변화 없음에도 실행되는 경우 발생 - isChanged를 추가하고 init일 때를 대비해서 검사 조건을 추가함
- 4번째 에러인 도로 전체 아이콘 없앤 후 새로고침하면 도로가 칠해지는 현상 해결 - 색상 값이 잘못들어가 있었다. 아마 문제 자체는 리팩토링하면서 해결되었을 것으로 추정
- 지하철의 defaultStyle에 width를 추가해서 새로고침 후에도 선이 유지되도록 변경
- 채도 / 명도가 들어오면 넘기지 않고 리턴시킨다. - 이전에 색상이 들어오기 때문에 한번만 칠할 수 있게 된다
- 청사진 테마 아마 마지막 수정?
- manageCategories에서 은솔님과 발생한 conflict를 if문 추가로 해결
qkrdmstlr3
requested review from
yyjjjj,
Eunsol0410,
GodDrinkTeJAVA and
gitgitWi
Eunsol0410
reviewed
Dec 14, 2020
| case ElementNameType.labelIcon: { | ||
| update[element] = combineStyle({ | ||
| style: elementStyle[element] as StyleActionPayload, | ||
| defaultStyle: update[element] as StyleType, |
There was a problem hiding this comment.
제가 조건문 추가하다가 실수가 있었나보네요~
|
꼼꼼하게 체크해주셔서 감사합니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
상세사항