Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockContent 서버 동기화 #120

Merged
merged 4 commits into from
Dec 16, 2020
Merged

BlockContent 서버 동기화 #120

merged 4 commits into from
Dec 16, 2020

Conversation

YiSoJeong
Copy link
Collaborator

BlockContent 서버 동기화

해당 이슈 📎

#118

변경 사항 🛠

BlockContent가 포커스 아웃 되었을 때마다 서버와 동기화 해준다.

테스트 ✨

없음

리뷰어 참고 사항 🙋‍♀️

@YiSoJeong YiSoJeong added 🐣 feature New feature or request 💯 must 🌈 frontend Frontend issue labels Dec 15, 2020
@YiSoJeong YiSoJeong added this to the 4차 릴리즈 milestone Dec 15, 2020
@YiSoJeong YiSoJeong self-assigned this Dec 15, 2020
Copy link
Collaborator

@skid901 skid901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ^^7

Copy link
Collaborator

@domino8788 domino8788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
우리 모두 화이팅!

useEffect(() => {
(async () => {
const { block: updatedBlock } = await updateBlock(blockDTO);
setBlockMap({ ...blockMap, [blockDTO.id]: updatedBlock });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blur 될 때 update하면 Blur 되는 action을 하기전까지 서버에 변경사항이 반영 안되겠네요.
ex) 사용자가 입력을해도 focus가 변경되기전까진 변경요청이 발생하지 않음.
이 부분은 나중에 동시편집 구현할때 다시한번 고려해야할듯 합니다.

@domino8788 domino8788 merged commit 9803294 into dev-frontend Dec 16, 2020
@domino8788 domino8788 deleted the feat/118 branch December 16, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐣 feature New feature or request 🌈 frontend Frontend issue 💯 must
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants