서버 실시간 동기화 기능 구현 #154
Merged
서버 실시간 동기화 기능 구현 #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 수정이 발생하는 controller 로직을 middleware로 이동 - publish 컨트롤러 구현
domino8788
added
🔧 refactor
🐣 feature
skid901
approved these changes
Dec 20, 2020
Comment on lines
10
to
15
| blockRouter.post( | ||
| '/parent-id/:parentId', | ||
| objectIdValidator('parentId'), | ||
| errorHandler(blockController.create), | ||
| errorHandler(blockMiddleware.create), | ||
| blockController.publish, | ||
| ); |
There was a problem hiding this comment.
publish 로직을 위한 미들웨어를 만든 다음에, 컨트롤러 후행 파라미터로 등록하는 쪽이 더 좋지 않았을까요?
YiSoJeong
approved these changes
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
서버 실시간 동기화 기능 구현
해당 이슈 📎
#152
변경 사항 🛠
구현내용 요약
테스트 ✨
없음
리뷰어 참고 사항 🙋♀️