[BugFix] 실시간 편집 API 연동 시 발생한 문제 해결 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjeonghak
approved these changes
Nov 20, 2024
PMtHk
requested changes
Nov 20, 2024
| @@ -23,7 +23,7 @@ import { ContributorStatus } from '@/project/enum/contributor-status.enum'; | |||
| import { TaskEventResponse } from '@/task/dto/task-event-response.dto'; | |||
| import { UpdateInformation } from '@/task/domain/update-information.type'; | |||
|
|
|||
| const { json0 } = ShareDB.types; | |||
| const json0 = ShareDB.types.defaultType; | |||
There was a problem hiding this comment.
🟢
const { defaultType: json0 } = ShareDB.types;와 같은 형식도 나쁘지 않은 것 같습니다. 클라이언트 ESLint 에 있는 규칙이에요!
| } | ||
| } | ||
|
|
||
| private merge(change: TaskEvent, existing: Task) { | ||
| const updateTitle = change.title; | ||
| const existingTitle = existing.title; | ||
| const { event } = change; | ||
| console.log(change); |
PMtHk
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
close #105
작업 내용
taskId추가고민과 학습내용
스크린샷