Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 태스크 생성 API 구현 #39

Merged
merged 6 commits into from
Nov 11, 2024
Merged

[Feat] 태스크 생성 API 구현 #39

merged 6 commits into from
Nov 11, 2024

Conversation

yangchef1
Copy link
Collaborator

@yangchef1 yangchef1 commented Nov 9, 2024 •
edited
Loading

관련 이슈 번호

close #8

작업 내용

  • Task, Section 엔티티 클래스 작성
  • Task 생성 DTO 작성
  • Task 생성 API 구현

고민과 학습내용

  • 이거 왜 이미 merge된 commit이 같이 들어있죠 ...?! (DB 설정 commit)
  • section에 대한 존재 여부 검증 로직 추가했습니다 !

스크린샷

@yangchef1 yangchef1 added Feature 새로운 기능을 추가 BE 서버 작업 labels Nov 9, 2024
@yangchef1 yangchef1 self-assigned this Nov 9, 2024
PMtHk
PMtHk requested changes Nov 9, 2024
View reviewed changes
Copy link
Collaborator

@PMtHk PMtHk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 prettier 설정에 아래와 같이 설정해두어서, indent 가 두 글자여야 하는데,
조금 문제가 있는 것 같습니다. IDE 설정이 되어 있는지 한번만 확인 부탁드립니다.

  "useTabs": true,
  "tabWidth": 2,

apps/server/src/task/domain/task.entity.ts Show resolved Hide resolved
@yangchef1 yangchef1 changed the title [Feat] 태스크 생성 API를 구현 [Feat] 태스크 생성 API 구현 Nov 9, 2024
PMtHk
PMtHk previously approved these changes Nov 10, 2024
View reviewed changes
jjeonghak
jjeonghak previously approved these changes Nov 10, 2024
View reviewed changes
iam454
iam454 previously approved these changes Nov 10, 2024
View reviewed changes
Copy link
Collaborator

@iam454 iam454 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

희철님~ resolve conflict 부탁드립니당

@yangchef1 yangchef1 dismissed stale reviews from iam454, jjeonghak, and PMtHk via 3d33ef2 November 10, 2024 11:29
@yangchef1 yangchef1 merged commit 91563db into dev Nov 11, 2024
2 checks passed
PMtHk pushed a commit that referenced this pull request Nov 11, 2024
@yangchef1 @PMtHk
[Feat] 태스크 생성 API 구현 (#39)
b72ed50 
* chore: TypeORM, MySQL 연동

* feat: 태스크 생성 API 구현

* feat: Section 존재 여부 확인 로직 추가
@yangchef1 yangchef1 deleted the feat/#8 branch December 3, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjeonghak jjeonghak jjeonghak approved these changes

@PMtHk PMtHk PMtHk approved these changes

@iam454 iam454 Awaiting requested review from iam454

Assignees

@yangchef1 yangchef1

Labels
BE 서버 작업 Feature 새로운 기능을 추가
Projects
None yet
Milestone
사용자는 태스크를 생성할 수 있다.
Development

Successfully merging this pull request may close these issues.

태스크 생성 API를 구현한다.
4 participants
@yangchef1 @jjeonghak @iam454 @PMtHk