[Config] 서버 로깅 설정 및 오류 포멧 설정 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PMtHk
approved these changes
Nov 10, 2024
| const { statusCode } = context.switchToHttp().getResponse(); | ||
| const delay = Date.now() - now; | ||
| this.logger.log( | ||
| `[RESPONSE] ${method} ${url} ${ip} - ${statusCode} \x1b[33m+${delay}ms\x1b[0m` |
There was a problem hiding this comment.
🟢
템플릿 리터럴이 길어지면 무슨 역할을 하는지 알아보기가 힘들어진다는 피드백을 받았던 적이 있습니다!
아직 짧아서 괜찮지만, createResponseLog 등의 함수로 분리하는 것도 좋아보입니다~~
| import { tap } from 'rxjs'; | ||
|
|
||
| @Injectable() | ||
| export class HttpLoggingInterceptor implements NestInterceptor { |
There was a problem hiding this comment.
🟢
클래스명과 파일명을 일치시키면 코드를 찾아가기가 좋을 것 같습니다.
그리고, import 시에도 더 용이할 것 같습니다.
There was a problem hiding this comment.
아 이 부분은 주의해야겠어요. 항상 파일이랑 클래스 이름 일치를 확인을 못하네요. 중간에 이름을 한번 바꾼거라..
|
아 추가로! 괜찮으시다면 하시던 작업 이후로는 레포지토리 클론 후 작업해주시면 감사하겠습니다!! |
iam454
reviewed
Nov 10, 2024
| @@ -2,9 +2,12 @@ import { Module } from '@nestjs/common'; | |||
| import { TypeOrmModule } from '@nestjs/typeorm'; | |||
| import { DataSource, DataSourceOptions } from 'typeorm'; | |||
| import { ConfigModule } from '@nestjs/config'; | |||
| import { APP_FILTER, APP_INTERCEPTOR } from '@nestjs/core'; | |||
| import { TypeormConfig } from '../config/typeorm.config'; | |||
There was a problem hiding this comment.
단순 궁금증인데,
상대 경로 나열되면 불편하진 않으신가요?
There was a problem hiding this comment.
절대 경로로 변경하는게 보기에 더 좋을까요? 이때까지 크게 불편함을 크게 느끼지 못해서 계속 사용하고 있었는데 수정해야겠네요
iam454
approved these changes
Nov 10, 2024
yangchef1
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
#2
작업 내용
고민과 학습내용
서버에서 http 요청이 올때 간단하게 로그를 남기고 응답을 할때나 오류가 발생했을때도 로그를 남기도록 설정했습니다.