Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 태스크 수정 API 구현 #52

Merged
merged 4 commits into from
Nov 11, 2024
Merged

[Feat] 태스크 수정 API 구현 #52

merged 4 commits into from
Nov 11, 2024

Conversation

yangchef1
Copy link
Collaborator

@yangchef1 yangchef1 commented Nov 11, 2024

관련 이슈 번호

close #14

작업 내용

  • 태스크 수정 API 구현

고민과 학습내용

섹션이 라벨 형태로도 제공된다고 생각해서, 위치 이동이 아닌 수정 시에도 변경할 수 있도록 했습니다 !

스크린샷

image

@yangchef1 yangchef1 added Feature 새로운 기능을 추가 BE 서버 작업 labels Nov 11, 2024
@yangchef1 yangchef1 self-assigned this Nov 11, 2024
Copy link
Collaborator

@PMtHk PMtHk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠르게 눈에 띄는 부분 위주로 작성해보았습니다.

PMtHk
PMtHk previously approved these changes Nov 11, 2024
iam454
iam454 previously approved these changes Nov 11, 2024
Copy link
Collaborator

@iam454 iam454 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당

Comment on lines +12 to +20
id: number;

title: string;

description: string;

sectionId: number;

position: number;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거는 무슨 코드에용????

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dto 필드 검증이 따로 필요할 것 같습니다. 저는 데코레이터 사용중이에요~

Copy link
Collaborator Author

@yangchef1 yangchef1 Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거는 무슨 코드에용????

DTO 칼럼 정의한 코드입니당 !

dto 필드 검증이 따로 필요할 것 같습니다. 저는 데코레이터 사용중이에요~

맞습니다.
필드 검증 추가해볼게요 !

jjeonghak
jjeonghak previously approved these changes Nov 11, 2024
@yangchef1 yangchef1 dismissed stale reviews from jjeonghak, iam454, and PMtHk via c1bd43c November 11, 2024 10:19
@yangchef1 yangchef1 merged commit 8fa6560 into dev Nov 11, 2024
2 checks passed
@yangchef1 yangchef1 deleted the feat/#14 branch December 3, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 서버 작업 Feature 새로운 기능을 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

태스크 수정 API를 구현한다.
4 participants