[Feat] 스냅샷 갱신 후에 섹션 변경 사항이 적용되지 않는 문제 해결 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjeonghak
approved these changes
Nov 14, 2024
PMtHk
approved these changes
Nov 18, 2024
| @@ -1,4 +1,4 @@ | |||
| import { Task } from '@/task/domain/task.entity'; | |||
| import { Task } from './task.entity'; | |||
| @@ -20,8 +20,8 @@ export class Snapshot { | |||
| }[]; | |||
| }[]; | |||
|
|
|||
| update(task: Task) { | |||
| const section = this.project.find((s) => s.id === task.section.id); | |||
| update(prevSectionId: number, task: Task) { | |||
There was a problem hiding this comment.
🟡
아 이부분에 대해서도 말씀드리려고 했습니다.
클라이언트 측에서 LexoRank 패지키를 이용해서 위치를 구한 다음에
해당 값을 전달해드리는 것에 대해 어떻게 생각하시나요?
낙관적 업데이트를 하기 위해서는 미리 계산해서 사용해야 할 필요성이 느껴져서요.
아침에 보여드린 프로토타입에서는 클라이언트 측에서 이를 사용했습니다!
There was a problem hiding this comment.
오 그렇군요 !
그럼 기존 update와 move로 분리된 엔드포인트를 합쳐도 괜찮을 것 같네요 !
There was a problem hiding this comment.
오 그렇군요 ! 그럼 기존 update와 move로 분리된 엔드포인트를 합쳐도 괜찮을 것 같네요 !
맞아요! 그렇게 변경하실건가요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
close #83
작업 내용
고민과 학습내용
스크린샷