[Feat] 프로젝트 생성 기능 구현 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PMtHk
approved these changes
Nov 18, 2024
| title: z | ||
| .string() | ||
| .min(1, 'Title is required.') | ||
| .regex(/^[a-zA-Z0-9 ]*$/, 'Only English letters and numbers are allowed.'), |
| register, | ||
| handleSubmit, | ||
| formState: { errors }, | ||
| } = useForm<CreateProjectRequestDTO>({ |
There was a problem hiding this comment.
🟢
Dto 가 약자임을 알지만, 저는 보통 Dto 라고 마무리합니다.
There was a problem hiding this comment.
ㅋㅋㅋ고민하다가 이렇게 했는데, 뭐로 맞출까용
| @@ -0,0 +1,83 @@ | |||
| import axios from 'axios'; | |||
There was a problem hiding this comment.
라우트에서 쿼리 동작을 분리하신 이유가 궁금해요~
There was a problem hiding this comment.
https://tanstack.com/router/latest/docs/framework/react/guide/external-data-loading#a-more-realistic-example-using-tanstack-query
TanStack/router#1563
요것들을 참고했습니다.
메인테이너인 도도씨가 loader는 캐시를 심기 위한 용도라고 하네요..
PMtHk
approved these changes
Nov 18, 2024
| }); | ||
|
|
||
| return ( | ||
| <TabView> |
There was a problem hiding this comment.
리뷰가 누락되어있는 것 같은데요!?
There was a problem hiding this comment.
그러네요
서스펜스에 대해 언급했었습니다.
useSuspenseQuery 가 적용되어 있는데, 해당 부분을 제가 못찾은 건지...
|
base response 적용해두겠습니다~ |
jjeonghak
approved these changes
Nov 18, 2024
yangchef1
approved these changes
Nov 18, 2024
|
정한님 적용 끝나면 수정할게용 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
#85
작업 내용
스크린샷
Screen.Recording.2024-11-18.at.8.23.43.PM.mov