refactor: findProfileByUserUuid 비즈니스 로직 서비스로 이동

boostcampwm2023 · Nov 5, 2024 · c3fcadf · c3fcadf
1 parent a895356
commit c3fcadf
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 4 deletions.
diff --git a/nestjs-BE/server/src/profiles/profiles.controller.spec.ts b/nestjs-BE/server/src/profiles/profiles.controller.spec.ts
@@ -60,7 +60,7 @@ describe('ProfilesController', () => {
     it('not found profile', async () => {
       jest
         .spyOn(profilesService, 'findProfileByUserUuid')
-        .mockResolvedValue(null);
+        .mockRejectedValue(new NotFoundException());
 
       const response = controller.findProfileByUserUuid(requestMock);
 

diff --git a/nestjs-BE/server/src/profiles/profiles.controller.ts b/nestjs-BE/server/src/profiles/profiles.controller.ts
@@ -7,7 +7,6 @@ import {
   UploadedFile,
   Request as Req,
   ValidationPipe,
-  NotFoundException,
   HttpStatus,
 } from '@nestjs/common';
 import { FileInterceptor } from '@nestjs/platform-express';
@@ -35,7 +34,6 @@ export class ProfilesController {
     const profile = await this.profilesService.findProfileByUserUuid(
       req.user.uuid,
     );
-    if (!profile) throw new NotFoundException();
     return { statusCode: HttpStatus.OK, message: 'Success', data: profile };
   }
 

diff --git a/nestjs-BE/server/src/profiles/profiles.service.spec.ts b/nestjs-BE/server/src/profiles/profiles.service.spec.ts
@@ -20,6 +20,7 @@ describe('ProfilesService', () => {
           provide: PrismaService,
           useValue: {
             profile: {
+              findUnique: jest.fn(),
               update: jest.fn(),
             },
           },
@@ -37,6 +38,31 @@ describe('ProfilesService', () => {
     uploadService = module.get<UploadService>(UploadService);
   });
 
+  describe('findProfileByUserUuid', () => {
+    const userUuid = 'user uuid';
+    const profile = { uuid: 'profile uuid', userUuid };
+
+    beforeEach(() => {
+      (prisma.profile.findUnique as jest.Mock).mockResolvedValue(profile);
+    });
+
+    it('found', async () => {
+      const res = profilesService.findProfileByUserUuid(userUuid);
+
+      await expect(res).resolves.toEqual(profile);
+    });
+
+    it('not found', async () => {
+      (prisma.profile.findUnique as jest.Mock).mockRejectedValue(
+        new NotFoundException(),
+      );
+
+      const res = profilesService.findProfileByUserUuid(userUuid);
+
+      await expect(res).rejects.toThrow(NotFoundException);
+    });
+  });
+
   describe('updateProfile', () => {
     const userUuid = 'user uuid';
     const profileUuid = 'profile uuid';

diff --git a/nestjs-BE/server/src/profiles/profiles.service.ts b/nestjs-BE/server/src/profiles/profiles.service.ts
@@ -18,7 +18,11 @@ export class ProfilesService {
   ) {}
 
   async findProfileByUserUuid(userUuid: string): Promise<Profile | null> {
-    return this.prisma.profile.findUnique({ where: { userUuid } });
+    const profile = await this.prisma.profile.findUnique({
+      where: { userUuid },
+    });
+    if (!profile) throw new NotFoundException();
+    return profile;
   }
 
   async findProfileByProfileUuid(uuid: string): Promise<Profile | null> {