Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

마인드맵 데이터 공유 버그 해결 #305

Merged
merged 3 commits into from
Dec 13, 2023
Merged

마인드맵 데이터 공유 버그 해결 #305

merged 3 commits into from
Dec 13, 2023

Conversation

hegleB
Copy link
Member

@hegleB hegleB commented Dec 13, 2023 •
edited by yang1318
Loading

관련 이슈

작업한 내용

  • navGraphViewModels를 사용하여 VIewModels 생명주기가 onCleared가 되지 않는 문제가 있어 뒤로가기 이벤트를 통해 crdtTree 클리어
  • 상대방이 삭제한 노드가 selectNode라면 선택 해제 해주도록 처리

@hegleB hegleB added the 🔨Fix 버그 해결 label Dec 13, 2023
@github-actions github-actions bot added the 📱AOS 안드로이드 작업 label Dec 13, 2023
@hegleB @yang1318 @jaehan4707
style: ktlint 적용
b2ea620 
Co-authored-by: yang1318 <[email protected]>
Co-authored-by: jaehan4707 <[email protected]>
jaehan4707
jaehan4707 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@jaehan4707 jaehan4707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이래서 navViewModel을 안쓰나봐요.. 더 좋은 방법이 있을거 같은데 흑흑

yang1318
yang1318 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@yang1318 yang1318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅠㅠ 생명주기 문제 까다롭네요.. 고생하셨습니다

@yang1318 yang1318 merged commit ab2c2ef into AOS-develop Dec 13, 2023
4 checks passed
@yang1318 yang1318 deleted the AOS-fix/mindmap-sharing branch December 14, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaehan4707 jaehan4707 jaehan4707 approved these changes

@yang1318 yang1318 yang1318 approved these changes

Assignees

@hegleB hegleB

@yang1318 yang1318

@jaehan4707 jaehan4707

Labels
📱AOS 안드로이드 작업 🔨Fix 버그 해결
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hegleB @yang1318 @jaehan4707