Composable 재사용 #329
Merged
Composable 재사용 #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaehan4707
reviewed
Mar 28, 2024
Comment on lines
+12
to
+27
| fun BackIconButton( | ||
| modifier: Modifier = Modifier, | ||
| onClick: () -> Unit, | ||
| iconColor: Color = Color.Black, | ||
| ) { | ||
| IconButton( | ||
| modifier = modifier, | ||
| onClick = onClick, | ||
| ) { | ||
| Icon( | ||
| painter = painterResource(id = R.drawable.ic_back), | ||
| contentDescription = null, | ||
| tint = iconColor, | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
버튼을 따로 component로 만들어서 재사용할 수있는건 좋은거 같아요!
그렇다면 Icon의 painter부분도 인자로 받아서, 하는건 어떨까요??
다른 FloatingAction 버튼도용
There was a problem hiding this comment.
그렇게 된다면 더 활용할 수 있는 영역이 넓어질거같아요!
There was a problem hiding this comment.
각 버튼의 기능을 명확하게 구분하고 가독성면에서도 더 좋다고 생각해서 저렇게 했습니다.
|
ktlint는 이제 빼야할거 같긴 하네요 ㅠ |
yang1318
approved these changes
Mar 29, 2024
yang1318
reviewed
Mar 29, 2024
|
서버 변경으로 핫픽스 과정에서 포함된거 같네요. 수정하도록 하겠습니다. |
jaehan4707
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업한 내용