-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
value class 및 contract를 이용한 when 문 제거 #332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
local.properties 적용
when 분기 처리 -> isRectangle 활용
when 분기 처리 -> isRectangle 활용
when 분기 처리 -> isRectangle 활용
when 분기 처리 -> isRectangle 활용
when 분기 처리 -> isRectangle 활용
음.. 아니면 isInsideNode를 NodePath의 확장함수로 구현하는건 어떤가요?? 확장함수면 context를 받아도 안이상할 것 같아서요! |
yang1318
approved these changes
Apr 13, 2024
hegleB
approved these changes
May 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NodePath를 확장함수로 구현해도 괜찮을꺼 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업한 내용
To Reviewers
현재 고민이 nodeView에 isInsideNode라는 함수가 있습니다.
근데 해당 함수는 Node class나 NodePath 클래스에 구현을 하는게 좋을거 같다고 생각하는데, 문제가 있어서 고민입니다ㅠ
현재 터치좌표에 대해서 모두 px 로 바꿔서 검사를 하는 과정이 있는데, Node 나 NodePath에 isInsideNode 함수를 구현할 경우,
context가 필요하다는 문제가 있습니다.
그렇다고 data class의 함수가 context를 갖는것은 좋은 방향성이 아니라고 생각하는데, 어떻게 해야할까요
제가 생각한 방향은 NodePath 내장함수로 isInsideNode를 구현하고, 해당 파라미터의 인자로 미리 px로 바꿔서 전달하는것인데,
이렇게 될 경우 파라미터의 길이가 너무 길어져서 고민입니다.
아마 이런 형태가 될 거 같은데 어떻게 생각하는지 궁금하네엽