Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ 배경
🔧 작업 내역
📝 리뷰 노트
FinishDelegate
여러 protocol로 세분화되어 있던
delegate
를CoordinatorFinishDelegate
하나로 통합시켰습니다.이렇게 delegate는 하나로 통합하고
Feature 레이어에 정의한
NavigationDelegate
의 구현부에서finish
메서드를 호출하는 것으로Coordinator
를 메모리에서 해제시킬 수 있습니다.SelectSong과 SaveJourney 코디네이터 통합
따로 분리되어 있던 Coordinator 두 개를 하나의 Flow로 생각해 통합했습니다.
SaveJourneyFlowCoordinator.swift
파일에서 확인하실 수 있습니다.해당 코디네이터는 SelectSong과 SaveJourney ViewController를 관리합니다.
📸 스크린샷