Merge pull request #459 from yaongmeow/be-feature/#458-fix-apple-login

[fix] LoginStrategy에서 email 필드 선택적 반환으로 전환
boostcampwm2023 · May 22, 2024 · e9d9163 · e9d9163
2 parents caa50cd + 330e809
commit e9d9163
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/BE/src/socialLogin/apple-login-strategy.ts b/BE/src/socialLogin/apple-login-strategy.ts
@@ -17,10 +17,13 @@ export class AppleLoginStrategy implements SocialLoginStrategy {
 
   async login(
     socialLoginRequestDto: SocialLoginRequestDto
-  ): Promise<{ resourceId: string; email: string }> {
+  ): Promise<{ resourceId: string; email?: string }> {
     try {
       const { idToken, email } = socialLoginRequestDto;
       const resourceId = (await this.decodeIdToken(idToken)).sub;
+      if (!email) {
+        return { resourceId };
+      }
       return { resourceId, email };
     } catch (error) {
       throw new UnauthorizedException('유효하지 않은 형식의 토큰입니다.');

diff --git a/BE/src/socialLogin/social-login-strategy.interface.ts b/BE/src/socialLogin/social-login-strategy.interface.ts
@@ -4,7 +4,7 @@ import { SocialLoginRequestDto } from './dto/social-login-request.dto';
 export interface SocialLoginStrategy {
   login(
     socialLoginRequestDto: SocialLoginRequestDto
-  ): Promise<{ resourceId: string; email: string }>;
+  ): Promise<{ resourceId: string; email?: string }>;
   withdraw(
     resourceId: string,
     socialWithdrawRequestDto: SocialWithdrawRequestDto