Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add headers for touches, covered_by, intersects, overlaps to doc #583

Merged

Conversation

tinko92
Copy link
Collaborator

@tinko92 tinko92 commented Apr 4, 2019

I'm sorry for the timing of this rather hastily put together pull request, however, I just now noticed that the documentation pages for covered_by, intersects, overlaps and touches are empty (since 1.65, in 1.64 they still had content) in the online documentation and the next release is already in the release candidate phase.

See https://www.boost.org/doc/libs/1_70_0_beta1/libs/geometry/doc/html/geometry/reference/algorithms/touches.html for example.

The result of this change is that some content shows up in the corresponding generated qbk files for these 4 algorithms which was not the case without the change (they had just 15 lines but no actual content), I'm not sure, though, whether this already fixes the issue. But with the release being so close I thought it might be more helpful to notify you in time with a possibly insufficient commit rather than trying to fully understand the documentation system.

@awulkiew
Copy link
Member

awulkiew commented Apr 4, 2019

Thanks! Yes this fixes the issue. I'm not sure if this will be released with 1.70 though.

@awulkiew awulkiew merged commit 82c69dd into boostorg:develop Apr 4, 2019
@mloskot
Copy link
Member

mloskot commented Apr 4, 2019

Good stuff, thanks!

@awulkiew awulkiew added this to the 1.71 milestone Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants