Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Function Autoloading #4
base: main
Are you sure you want to change the base?
[RFC] Function Autoloading #4
Changes from 4 commits
32d7763
3b92a1e
e54c5d6
1a57a5c
6b67108
478f50e
8045f86
8b93203
2165b7c
8af3667
453765e
4c6e47e
33ec8cb
36dfb64
94e242e
09e7794
eea5fcc
7bdb52e
b82b883
b229a0f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enhance understanding with examples for key terms.
Providing examples for the defined terms can help clarify their meanings.
+ For example, a **Defined function** might be one included via `require 'file.php';`.
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify the proposal with examples.
Including examples for changes to
spl_autoload_register
and new constants would improve clarity.+ Example: `spl_autoload_register($autoload_function, false, false, SPL_AUTOLOAD_FUNCTION);`
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expand on performance analysis.
Consider providing more detailed analysis or examples regarding the performance impact.
+ Example: If an autoloader expects a single argument, ensure it can handle the second argument gracefully.
Tools
LanguageTool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify sentence structure.
Consider revising the sentence to separate the clauses correctly.
Committable suggestion
Tools
LanguageTool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expand on performance and compatibility.
Consider providing more detailed analysis or examples regarding performance impact and handling mismatched arguments.
+ Example: If an autoloader expects a single argument, ensure it can handle the second argument gracefully.
Committable suggestion
Tools
LanguageTool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify Opcache impact.
The impact on Opcache is currently unspecified. Consider updating this section with any available insights or plans.
+ Update: Analyze potential Opcache changes or optimizations needed for function autoloading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep sections updated.
Ensure that open issues and future scope sections are updated as discussions and developments progress.
Would you like assistance in tracking these sections for updates?
Tools
LanguageTool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid inline HTML for voting choices.
Consider using Markdown alternatives to inline HTML for better compatibility and readability.
Committable suggestion
Tools
Markdownlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
References Well-Documented.
The references to past RFCs provide valuable context and are well-documented.
Keep Implementation Section Updated.
Ensure the implementation section is updated with relevant details once the project progresses.
Would you like assistance in tracking implementation updates?
Tools
Markdownlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep Rejected Features Updated.
Ensure the rejected features section is updated with features that are discussed and not included.
Would you like assistance in tracking rejected features?