fix: ComponentManager.install() deadlock #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screenshoot by moobell#1174 on Discord
|
jannuary
suggested changes
Dec 20, 2022
|
Looks good, I also stumbled upon problems if Bottles fails to download components. |
jannuary
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My internet sucks, manifest fetching and file download randomly failed.
when
ComponentManager.install()failed with downloading, it won't pop the failed installation fromself.__queue, next call toComponentManager.install()will keep waiting for empty queue forever.then Onboard Dialog will stuck at "Almost Done" forever.
Type of change
How Has This Been Tested?