Add some other fields to Benchmarks, Add Multi Dialect support to a benchmark, Improve Benchmark Output & simplify filtering benchmarks by tags #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Searching for benchmarks by type more conveniently. 2. Better visualization of results by using - varying_parameter. 3. Benchmark Support for multiple dialects
Merge new changes into test-bowtie-perf
…ying parameter benchmark
for more information, see https://pre-commit.ci
|
@Julian, the tests wont pass in the benchmarks PR if I included it separately so I included their changes as well in this PR. If its too much then I can put it in a separate one and then that one could be merged later then the tests would pass. Do let me know if you want that. |
Julian
reviewed
Aug 8, 2024
Julian
reviewed
Aug 8, 2024
Julian
reviewed
Aug 8, 2024
Julian
reviewed
Aug 8, 2024
Co-authored-by: Julian Berman <[email protected]>
sudo-jarvis
force-pushed
the
test-bowtie-perf
branch
from
f827ad0 to
c112624
Compare
Julian
reviewed
Aug 14, 2024
| exit_code=0, | ||
| ) | ||
|
|
||
| expected_data1 = """ |
There was a problem hiding this comment.
Can you use textwrap.dedent to make these a bit less "ugly" indented in a follow-up PR? Will merge for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multi dialect support to a benchmark.
Improve Benchmark Output for pretty and markdown output by grouping according to varying_parameter if possible.
Simplify filtering benchmarks according to benchmark_type.
📚 Documentation preview 📚: https://bowtie-json-schema--1425.org.readthedocs.build/en/1425/