Added support for cell formats when writing Excel files

[eisberg]

Added support for cell formats when writing Excel files

Example:

$style = (new StyleBuilder())
            ->setFontBold()
            ->setFormat('0.00')//Builtin format
            ->build();

$style2 = (new StyleBuilder())
            ->setFontBold()
            ->setFormat('0.000')
            ->build();

[boxcla]

Verified that @eisberg has signed the CLA. Thanks for the pull request!

[amiri27]

Any update regarding this?!

[eisberg]

I'm really looking forward to the confirmation of this request, too.

[adrilo]

nitpick: can be simplified $id = self::$builtinNumFormatToIdMapping[$format] ?? $this->formatIndex++;

[adrilo]

nitpick: can be simplified: return $this->styleIdToFormatsMappingTable[$styleId] ?? null;

[adrilo]

including the default one

[adrilo]

can you add a test here? See StyleRegistryTest.php for examples

[adrilo]

maybe add a test in StyleBuilderTest?

[adrilo]

Thanks for the PR!

[amiri27]

Thanks @adrilo and well done @eisberg ..

[adrilo]

As a follow-up, we need to update the documentation.

[madflow]

Is this a XSLX only feature? Does ODS not have cell formats?

[adrilo]

Right! We should also add that feature to ODS. Though I figured that asking people to implement both XLSX and ODS for every feature is too demanding. Usually people only need a feature for a specific file format. That's why I merged that one.

See #687

[madflow]

@adrilo Okay. I respect that - but I disagree. I do not think it is to demanding do expect a fully implemented feature and docs in a PR. This repo has > 2600 stars and is heavily used. We can demand something ;)

Usually people only need a feature for a specific file format.

We use XLSX and ODS.