Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Comment : Issue # https://github.com/boxblinkracer/cypress-tes… #48

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

vijigit
Copy link
Contributor

@vijigit vijigit commented Oct 16, 2023

…trail/issues/47

@boxblinkracer
Copy link
Owner

Hi @vijigit
so sorry for not coming back earlier

the reason why it says this, is that one knows, its from Cypress.
from what I understand, your PR changes that to have the title of cypress, inside the TestRail result-comment, right?
which indeed makes sense

im only wondering, isnt the convertedTest.getTitle always valid?
so the fallback with the original text should (in theory) never happen right?
that is only a security fallback?

@vijigit
Copy link
Contributor Author

vijigit commented Jan 2, 2024

Hi @boxblinkracer
Yes, that is right, it adds only the title of the test case, However , It adds more value when the title is dynamic, For example if I am testing the same tescase for 3 different users using fixtures, then it adds for which user the test case is tested for and what is the result say success/failed

@boxblinkracer
Copy link
Owner

Hi

yes, I meant more the fallback stuff
but it's great, I like it

i will just resolve the conflicts and merge it

thank you so much for this

@boxblinkracer boxblinkracer merged commit 5f30614 into boxblinkracer:master Jan 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants